On Wed, 2017-03-08 at 14:17 +0100, Arend Van Spriel wrote: > > > +void ieee80211_check_rate_mask(struct ieee80211_sub_if_data > > *sdata) > > +{ > > + struct ieee80211_local *local = sdata->local; > > + struct ieee80211_supported_band *sband; > > + u32 user_mask, basic_rates = sdata- > > >vif.bss_conf.basic_rates; > > + enum nl80211_band band; > > + > > + if (WARN_ON(!sdata->vif.bss_conf.chandef.chan)) > > + return; > > + > > + if (WARN_ON_ONCE(!basic_rates)) > > + return; > > + > > + band = sdata->vif.bss_conf.chandef.chan->band; > > + user_mask = sdata->rc_rateidx_mask[band]; > > + sband = local->hw.wiphy->bands[band]; > > + > > + basic_rates = sdata->vif.bss_conf.basic_rates; > > basic_rates has already been initialized (and checked) above so this > is > redundant. Huh, yeah, good catch - will fix. johannes