On Sat, 2017-03-04 at 11:10 +0200, Jouni Malinen wrote: > On Tue, Feb 21, 2017 at 11:31:18AM +0100, Johannes Berg wrote: > > Currently, hwsim is reporting survey data (only a fake noise floor) > > for the current channel. This breaks when the multi-channel support > > is enabled since then there's no current channel. > > > > Make the dummy implementation closer to a real one and only report > > data while scanning, for all the scanned channels. At other times, > > no survey data might be available (in real hardware) due to power- > > save for example. > > Had this lying around - is it useful for anyone? > > Yes, it seems to make the ap_acs hwsim test cases in hostap.git quite > a > bit more useful in hitting proper acs.c coverage in hostapd.. And > also > allow having to have hacks to force previous AP instance on the same > band just to be able to hit any of this code. > > > - survey->filled = SURVEY_INFO_NOISE_DBM; > > + survey->filled = SURVEY_INFO_NOISE_DBM | > > + SURVEY_INFO_CHANNEL_TIME | > > + SURVEY_INFO_CHANNEL_TIME_BUSY; > > This is pretty old, though.. :) Had to remove the "CHANNEL_" part > here.. > > > + survey->channel_time = > > + survey->channel_time_busy = survey->channel_time/8; > > .. and "channel_" in these to make this compile. Right, yeah. > Anyway, with those > trivial changes, the hwsim test cases did start looking more > interesting, so it would seem reasonable to get this applied. Applied it now with the fixes. johannes
