On 3-3-2017 13:28, Johannes Berg wrote: >> +void cfg80211_connect_done(struct net_device *dev, const u8 *bssid, >> + struct cfg80211_bss *bss, const u8 >> *req_ie, >> + size_t req_ie_len, const u8 *resp_ie, >> + size_t resp_ie_len, const u8 *fils_kek, >> + size_t fils_kek_len, bool >> update_erp_seq_num, >> + u16 fils_erp_seq_num, const u8 *pmk, >> size_t pmk_len, >> + const u8 *pmkid, int status, gfp_t gfp, >> + enum nl80211_timeout_reason >> timeout_reason); > Ouch. Please declare most of those (perhaps other than dev) as a > structure and pass a pointer here. > > Also, why require the BSSID when BSS is set? Seems you could say one or > the other. The BSSID/BSS behaviour is already present in current cfg80211_connect_bss(). bss may be NULL which will result in lookup using the given bssid. Regards, Arend
