On Wed, Jun 11, 2008 at 3:58 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: > On Wed, Jun 11, 2008 at 02:12:41PM +0200, Johannes Berg wrote: >> >> > Johannes -- why do we have the requirement for NETDEVICES_MULTIQUEUE >> > on CONFIG_MAC80211_QOS? My current config doesn't have it it and >> > CONFIG_MAC80211_QOS still works right now enabled. Of course the >> > driver I'm testing doesn't have 11n though. >> >> because otherwise skb_get_queu_mapping always returns 0 and you use only >> one queue. >> >> > Shouldn't we just make MAC80211_QOS depend on NET_SCHED and figure out >> > we can't support 11n based on NETDEVICES_MULTIQUEUE? >> >> no, 11e also needs multiple queues. > > Thanks, since MAC80211_QOS was there before the issue is some > kernels may have this enabled but they never got to MQ. This is why > certain compiles will complain about missing symbols. > > So how about we disable it if we determine MQ and NET_SCHED are off? > Like this: > > diff --git a/config.mk b/config.mk > index e8dc469..b72e37e 100644 > --- a/config.mk > +++ b/config.mk > @@ -27,7 +27,16 @@ ifeq ($(shell test $(KERNEL_SUBLEVEL) -lt 23 && echo yes),yes) > CONFIG_MAC80211_QOS=y > else > ifeq ($(CONFIG_NETDEVICES_MULTIQUEUE),) > -$(warning "WARNING: You are running a kernel >= 2.6.23, you should enable CONFIG_NETDEVICES_MULTIQUEUE for 802.11n support") > +ifeq ($(CONFIG_NET_SCHED),) > +$(warning "WARNING: You are running a kernel >= 2.6.23, you should enable CONFIG_NETDEVICES_MULTIQUEUE and CONFIG_NET_SCHED for 802.11[ne] support") > +else > +# Disable CONFIG_MAC80211_QOS if you had it enabled befofre in your old .config > +$(warning "WARNING: You are running a kernel >= 2.6.23, you should enable CONFIG_NETDEVICES_MULTIQUEUE for 802.11[ne] support") > +CONFIG_MAC80211_QOS=n > +endif > +else > +# Disable CONFIG_MAC80211_QOS if you had it enabled befofre in your old .config > +CONFIG_MAC80211_QOS=n > endif > endif > endif > One thing it's not clear for me. What do you mean by old .config CONFIG_MAC80211_QOS flags is available only in wireless-testing? The makefile is feed by compat.mk and DOTconfig from the target kernel (KLIB) (in my case 2.6.25) >From what I see the flags from wireless-testing need to be always reflected in compat.mk. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
