On Wed, Jun 11, 2008 at 2:03 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: > On Tue, Jun 10, 2008 at 9:36 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: >> On Tue, Jun 10, 2008 at 9:32 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: >>> On Tue, Jun 10, 2008 at 4:57 PM, Tomas Winkler <tomasw@xxxxxxxxx> wrote: >>>> On Mon, Jun 9, 2008 at 1:25 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: >>>>> On Mon, Jun 9, 2008 at 2:01 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: >>>>>> On Mon, Jun 9, 2008 at 1:56 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >>>>>>> On Mon, 2008-06-09 at 10:53 +0300, Ron Rindjunsky wrote: >>>>>>>> > >>>>>>>> > I just finished trying to backport CONFIG_NETDEVICES_MULTIQUEUE >>>>>>>> > requirement for 802.11n to older kernels by relying on the old >>>>>>>> > internal mac80211 hacked up MQ support. I've tested the build on >>>>>>>> > 2.6.22, 2.6.23, and 2.6.24. Let me know if you get to test this, >>>>>>>> > particularly iwl4965 using 11n on 2.6.22. >>>>>>>> > >>>>>>>> >>>>>>>> in config.mk you put MAC80211_QOS=m, and i guess that the intention was to put >>>>>>>> CONFIG_MAC80211_QOS=m >>>>>>>> if this is the case then the compilation fails >>>>>>> >>>>>>> It should be "y" >>>>>>> >>>>>>> johannes >>>>>>> >>>>>> >>>>>> Danke >>>>> >>>>> OK found some more issues. v4.2 pushed out and new tarball >>>>> regenerated. This has been tested by Intel on 802.11n on iwl4965. >>>> >>>> I couldn't make wme.c compiled for kernels > 22 unless I've added the >>>> else statement bellow into confg.mk >>>> You've reported that it worked for you so what did I wrong? >>>> >>>> ifeq ($(CONFIG_NETDEVICES_MULTIQUEUE),) >>>> $(warning "WARNING: You are running a kernel >= 2.6.23, you should >>>> enable CONFIG_NETDEVICES_MULTIQUEUE for 802.11n support") >>>> else >>>> CONFIG_MAC80211_QOS=y >>> >>> Well this is forcing this option on kernels where it probably was >>> available. I don't recall where we added this but I was relying on >>> your .config. We forced this for older kernels as we are providing the >>> infrastructure within the code but for newer kernels you need MQ >>> support and NET_SCHED. If we force enable it and if those options are >>> not enabled it'll fail. This is why we have this big fat warning if MQ >>> is detected as disabled for >= 2.6.23. >>> >>> Let me know what you think. >> >> OK I guess we should just enable it if MQ is enabled, point taken. >> Committed and pushed, thanks. > > Actually no, take that back. CONFIG_MAC80211_QOS should probably just > be enabled if NET_SCHED is present. > > Johannes -- why do we have the requirement for NETDEVICES_MULTIQUEUE > on CONFIG_MAC80211_QOS? My current config doesn't have it it and > CONFIG_MAC80211_QOS still works right now enabled. Of course the > driver I'm testing doesn't have 11n though. > > Shouldn't we just make MAC80211_QOS depend on NET_SCHED and figure out > we can't support 11n based on NETDEVICES_MULTIQUEUE? > > Luis > We need both to be enabled NET_SCHED and MULTIQUEUE for both WME and HT. Both features requires multiple queues and scheduling. Tomas; -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
