On 8 February 2017 at 10:54, Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: > On 2-2-2017 22:33, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@xxxxxxxxxx> >> >> This will allow getting struct device reference from the passed >> brcmf_pub for the needs of dev_err. More detailed messages are really >> important for home routers which frequently have 2 (or even 3) wireless >> cards supported by brcmfmac. >> >> Note that all calls are yet to be updated as for now brcmf_err macro >> always passes NULL. This will be handled in following patch to make this >> change easier to review. > > I prefer brcmf_err() to have struct device reference directly instead of > using brcmf_pub. That would remove the need for patches 5 till 7 as bus > specific code already has struct device. So I have acked the first three > patches, but would like to revise 8 and 9. I'm a bit disappointed as this change of mind means I wasted quite some time by reworking all brcmf_err calls :( I intentionally sent [PATCH RFC 2/2] brcmfmac: add brcmf_err_pub macro for better error messages 2 weeks before the final patch, to make sure my design is alright & can be accepted :( I'll work on another version of this patch & will send it as early RFC. -- Rafał
