On 21-2-2017 12:34, Arend Van Spriel wrote: > On 21-2-2017 11:40, Johannes Berg wrote: >> On Tue, 2017-02-21 at 11:32 +0100, Arend Van Spriel wrote: >>> On 21-2-2017 11:09, Johannes Berg wrote: >>>> From: Eliad Peller <eliad@xxxxxxxxxx> >>>> >>>> Let drivers advertise support for station-mode 4-way handshake >>>> offloading with a new >>>> NL80211_EXT_FEATURE_4WAY_HANDSHAKE_OFFLOAD_STA >>>> flag. >>> >>> I find use of the term OFFLOAD a bit redundant as it is implied by >>> its presence anyway. >> >> Fair enough, we can remove that. >> >>>> Add a new NL80211_ATTR_PMK attribute that might be passed as part >>>> of NL80211_CMD_CONNECT command, and contain the PSK (which is the >>>> PMK, hence the name.) > > It is also added to NL80211_CMD_ASSOCIATE. Maybe worth mentioning. > >>>> The driver/device is assumed to handle the 4-way handshake by >>>> itself in this case (including key derivations, etc.), instead >>>> of relying on the supplicant. > > What I am also missing is how to deal with NL80211_CMD_CONNECTED event > signalling. Should that be given after (un)successful completion of the > 4-way handshake or should we have a separate event for that? > > Regards, > Arend > >>>> This patch is somewhat based on this one (by Vladimir Kondratiev): >>>> https://patchwork.kernel.org/patch/1309561/. >>> >>> It also looks quite like this one we posted a while ago [1]. Our bad >>> that we did not follow-up :-p >> >> Indeed, I was looking for the better link (had gmane recorded in the >> internal commit log) and found a few that all looked the same ... :) >> >> Would this work for you? We should have wpa_supplicant support too, but >> need to ask Andrei to look at that. Forgot to reply to this. Yes, this will work. Can come up with wpa_supp changes. Regards, Arend
