Felix Fietkau <nbd@xxxxxxxx> writes:
> On 2017-02-12 16:22, Toke Høiland-Jørgensen wrote:
>> Felix Fietkau <nbd@xxxxxxxx> writes:
>>
>>> ath_tx_count_airtime is doing a lot of unnecessary work:
>>>
>>> - Redundant station lookup
>>> - Redundant rcu_read_lock/unlock
>>> - Useless memcpy of bf->rates
>>> - Useless NULL check of bf->bf_mpdu
>>> - Redundant lookup of the skb tid
>>>
>>> Additionally, it tries to look up the mac80211 queue index from the txq,
>>> which fails if the frame was delivered via the power save queue.
What does this mean in practise, what's the user level impact?
>>> This patch fixes all of these issues by passing down the right set of
>>> pointers instead of doing extra work
>>>
>>> Cc: stable@xxxxxxxxxxxxxxx
>>> Fixes: 63fefa050477 ("ath9k: Introduce airtime fairness scheduling
>>> between stations")
>>> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
>>
>> Not sure if there's anything for stable to do with this; don't think the
>> airtime fairness code has gone into a release yet? Otherwise:
>>
>> Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>
>
> I added this, because I'm not sure this patch will make it to 4.10 in
> time, since we're really close to a release. I assume this patch will
> probably go into 4.11.
Yeah, to try to get a patch to 4.10 at this point needs to be a really
high profile regression. That is if Linus doesn't release 4.10 today, of
course.
--
Kalle Valo
