Search Linux Wireless

Re: [RFC-PATCH] mac80211: eliminate cached fc from struct ieee80211_{tx|rx}_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-06-09 at 17:28 -0700, Harvey Harrison wrote:
> Rather than keep a cached host-endian frame control, use byteswapped
> helpers throughout and get the frame control directly from the 802.11
> frame itself.
> 
> Very little testing has been done so far of this, but it does compile.
> 
> Applies on top of the 8-patch series adding byteswapped frame control
> helpers.

Cool. I'll test it later.


> -	case (IEEE80211_FCTL_TODS | IEEE80211_FCTL_FROMDS):
> +	if (ieee80211_has_a4(fc)) {

I wonder if the compiler was smart enough to make the switch statement
into something like

if (fromds) {
	if (tods) {
		...
	} else {
		...
	}
} else {
	if (tods) {
		...
	} else {
		...
	}
}

and if we should do that?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux