> Rafał Miłecki [mailto:zajec5@xxxxxxxxx] wrote: > On 7 February 2017 at 20:12, Steve deRosier <derosier@xxxxxxxxx> wrote: > >> + /* look for all matching property names */ > >> + for_each_property_of_node(priv->dt_node, prop) { if > >> + (strcmp(prop->name, "marvell,2ghz") == 0) > >> + priv->disable_2g = true; > >> + if (strcmp(prop->name, "marvell,5ghz") == 0) > >> + priv->disable_5g = true; > >> + if (strcmp(prop->name, "marvell,chainmask") == 0) { prop_value = > >> + be32_to_cpu(*((__be32 *)prop->value)); if (prop_value == 2) > >> + priv->antenna_tx = ANTENNA_TX_2; > >> + > >> + prop_value = be32_to_cpu(*((__be32 *) (prop->value + 4))); if > >> + (prop_value == 2) > >> + priv->antenna_rx = ANTENNA_RX_2; > >> + } > >> + } > >> + > >> + priv->pwr_node = of_find_node_by_name(priv->dt_node, > >> + "marvell,powertable"); > >> +#endif > >> +} > > > > AFAICT, there's no documentation for these DT bindings. The mwlwifi > > node and the marvell,powertable both need full documentation in > > Documentation/devicetree/bindings/... . > > > > Frankly I have a feeling I'm going to need these DT nodes and I'd like > > to not have to guess-and-check based on the code. > > Please use ieee80211-freq-limit: > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=b3 > 30b25eaabda00d74e47566d9200907da381896 > > Most likely with wiphy_read_of_freq_limits helper: > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=e6 > 91ac2f75b69bee743f0370d79454ba4429b175 I already replied meaning of these parameters: <marvell,2ghz> is used to disable 2g band. <marvell,5ghz> is used to disable 5g band. <marvell, chainmask> is used to specify antenna number (if default number is suitable for you, there is no need to use this parameter). <marvell,powertable> should not be used for chip with device power table. In fact, this parameter should not be used any more. Thanks, David
