Search Linux Wireless

Re: [PATCH 2/2] brcmfmac: be more verbose when PSM's watchdog fires

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30-1-2017 16:09, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
> 
> It's important to inform user so he knows things went wrong. He may also
> want to get memory dump for further debugging purposes.

Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
> index 6f8a4b074c31..f4644cf371c7 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
> @@ -58,10 +58,18 @@ static int brcmf_debug_psm_watchdog_notify(struct brcmf_if *ifp,
>  					   const struct brcmf_event_msg *evtmsg,
>  					   void *data)
>  {
> +	int err;
> +
>  	brcmf_dbg(TRACE, "enter: bsscfgidx=%d\n", ifp->bsscfgidx);
>  
> -	return brcmf_debug_create_memdump(ifp->drvr->bus_if, data,
> -					  evtmsg->datalen);
> +	brcmf_err("PSM's watchdog has fired!\n");
> +
> +	err = brcmf_debug_create_memdump(ifp->drvr->bus_if, data,
> +					 evtmsg->datalen);
> +	if (err)
> +		brcmf_err("Failed to get memory dump, %d\n", err);
> +
> +	return err;
>  }
>  
>  void brcmf_debugfs_init(void)
> 



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux