On 27-1-2017 13:31, Johannes Berg wrote: > On Fri, 2017-01-27 at 12:09 +0000, Arend van Spriel wrote: >> For wowlan netdetect a separate limit is defined for the number of >> matchsets. Currently, this limit is ignored and the regular limit >> for scheduled scan matchsets, ie. struct wiphy::max_match_sets, is >> used for the net-detect case as well. >> > > But .. this patch shouldn't be first in the series, should it? That > leaves brcmfmac broken inbetween. > > Also, since you fix the brcmfmac value in patch 2, and it's the same in > both cases, I don't really see a dependency of anything *on* the > nl80211 patch? The brcmfmac changes can go in without it entirely, and > have no effect whatsoever, no? Patch 4 depends on patch 2. Patch 1 and 2 were a single patch, but I decided to separate them. So yeah, now patch 1 actually depends on patch 2 in order not to break brcmfmac. > IOW, I think Kalle can merge 2-5, and I can then pick up this one when > they hit net-next and I've synchronized, no? Agree. Regards, Arend
