Hi, On 24 January 2017 at 16:18, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2017-01-20 at 09:55 +0100, Andrew Zaborowski wrote: >> Support .set_cqm_rssi_range_config if the beacons are available for >> processing in mac80211. There's no reason that this couldn't be >> offloaded by mac80211-based drivers but there's no driver method for >> that added in this patch as I don't have the hardware. > > I thought you only required now that the level was given or something > like that, so most HW should support it? There's not much you can do with the current CQM one-threshold mechanism so drivers will need this new method unfortunately. > >> The NL80211_EXT_FEATURE_CQM_RSSI_LIST feature is automatically set >> during ieee80211_register_hw if the default interface being created >> doesn't indicate beacon filtering enabled. For drivers that don't >> want a default interface but want to support this feature the flag >> needs to be set explicitly in the driver. >> >> Signed-off-by: Andrew Zaborowski <andrew.zaborowski@xxxxxxxxx> >> --- >> changes in v3: >> - set NL80211_EXT_FEATURE_CQM_RSSI_LIST automatically in >> ieee80211_register_hw based on the default interface's >> IEEE80211_VIF_BEACON_FILTER flag. This is a bit of an RFC as I'm >> not sure how practical it is for a driver to allow creation of >> additional interfaces that also implement CQM, but which filter >> beacons in the firmware. In any case userspace would only >> receive EOPNOTSUPP on those addiitonal interfaces when trying to >> use the feature. > > That can't possibly work, since the flag can't be set by a driver at > this point - the interface isn't brought up yet, so the driver knows > nothing about it. True... I'd assumed ieee80211_if_add would result in drv_add_interface perhaps because of name similarity. I'll update the patches. Best regards
