Search Linux Wireless

Re: [PATCH 5/6] brcmfmac: modify all brcmf_err calls adding struct brcmf_pub

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafał,

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on next-20170124]
[cannot apply to v4.10-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-switch-to-C-function-__brcmf_err-for-printing-errors/20170125-033714
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c: In function 'brcmf_cfg80211_vndr_cmds_dcmd_handler':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c:44:3: warning: 'pub' may be used uninitialized in this function [-Wmaybe-uninitialized]
      brcmf_err(pub, "vendor command too short: %d\n", len);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~           

vim +/pub +44 drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c

    28	#include "fwil.h"
    29	
    30	static int brcmf_cfg80211_vndr_cmds_dcmd_handler(struct wiphy *wiphy,
    31							 struct wireless_dev *wdev,
    32							 const void *data, int len)
    33	{
    34		struct brcmf_cfg80211_vif *vif;
    35		struct brcmf_if *ifp;
    36		struct brcmf_pub *pub;
    37		const struct brcmf_vndr_dcmd_hdr *cmdhdr = data;
    38		struct sk_buff *reply;
    39		int ret, payload, ret_len;
    40		void *dcmd_buf = NULL, *wr_pointer;
    41		u16 msglen, maxmsglen = PAGE_SIZE - 0x100;
    42	
    43		if (len < sizeof(*cmdhdr)) {
  > 44			brcmf_err(pub, "vendor command too short: %d\n", len);
    45			return -EINVAL;
    46		}
    47	
    48		vif = container_of(wdev, struct brcmf_cfg80211_vif, wdev);
    49		ifp = vif->ifp;
    50		pub = ifp->drvr;
    51	
    52		brcmf_dbg(TRACE, "ifidx=%d, cmd=%d\n", ifp->ifidx, cmdhdr->cmd);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux