On Sat, 21 Jan 2017 21:01:32 +0100 Linus Lüssing <linus.luessing@xxxxxxxxx> wrote: > +static bool br_port_group_equal(struct net_bridge_port_group *p, > + struct net_bridge_port *port, > + const unsigned char *src) > +{ > + if (p->port != port) > + return false; > + > + if (!(port->flags & BR_MULTICAST_TO_UNICAST)) > + return true; > + > + return ether_addr_equal(src, p->eth_addr); > +} > + I prefer that argument to functions like this be const.