Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > The firmware is read from disk as a little-endian byte string. The code > that loads the firmware into the device transfers it as 4-byte quantities. > The routines that write multi-byte quantities on BE hardware assume that > the data are in CPU order, and automatically do the conversion to the LE > order required by the device. As a result, the firmware is transmitted > incorrectly. Rather than do multiple byte swaps on the data, the download > routine is revised to transmit bytes rather than dwords. Although the > number of I/O operations is increased, the firmware is not often loaded. > > All drivers have the same bug, and use essentially the same code to > download firmware. These routines have been moved into rtlwifi. > > Some CamelCase variables have been renamed. > > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx> 3 patches applied to wireless-drivers-next.git, thanks. 89d32c9071aa rtlwifi: Download firmware as bytes rather than as dwords 69d8597e9fe5 rtlwifi: rtl8192cu: Calculate descriptor checksum correctly for BE 106e0deca1ac rtlwifi: rtl8192cu: Convert driver to use common macros -- https://patchwork.kernel.org/patch/9526749/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
