Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > On 01/18/2017 08:49 AM, Kalle Valo wrote: >> Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: >>> The previous commit changes the debug system to use a mask to select >>> which components are to be debugged. Now, we add the necessary code >>> to change the mask from sysfs. >>> >>> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> >>> Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> >> There's already a generic sysfs interface to change module parameters in >> /sys/module/<driver>/parameters, drivers should not have a private interface for >> that. > > Kalle, > > I was not aware of that part of sysfs. I will respin the patch as well > as remove the old code that set the debug level. Good, thanks. I dropped the whole series now and assume that you will send v2. -- Kalle Valo
