On 18 January 2017 at 09:58, Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: > On 17-1-2017 17:34, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@xxxxxxxxxx> >> >> Function brcmf_c_set_joinpref_default is in common.c, so move it to the >> related header. All other (touched) ones are in core.c so take them out >> of the bus.h. >> I just needed to include bus.h to have enum brcmf_bus_state defined. > > I prefer to keep the bus api in separate include file so please leave > those. That leaves the move of brcmf_c_set_joinpref_default(). Please > send a v2 and consider it acked by me. Oh, I just realized there isn't bus.c! Would that make sense to move these functions from core.c to new bus.c then? -- Rafał
