On Wed, Jan 11, 2017 at 02:26:06PM +0100, Johannes Berg wrote: > On Wed, 2017-01-11 at 13:13 +0000, Malinen, Jouni wrote: > > > > > > @@ -172,6 +174,7 @@ static int cfg80211_conn_do_work(struct > > > > wireless_dev *wdev) > > > > case CFG80211_CONN_AUTH_FAILED: > > > > + *treason = NL80211_TIMEOUT_AUTH; > > > > > > ... but it seems AUTH failure always is a timeout? > > > > The CFG80211_CONN_AUTH_FAILED case is currently used only in > > cfg80211_sme_auth_timeout() which is indeed always a timeout. > > Might be worth simply renaming it, since you have the reason there > unconditionally? Sure, that sounds fine and documents the existing case more accurately. -- Jouni Malinen PGP id EFC895FA
