> -----Original Message-----
> > + * @relative_rssi_set: Indicates whether @relative_rssi is set or not.
>
> So you see a use-case for doing a scan with @relative_rssi being zero, right?
Yes. Zero value for relative_rssi is also valid.
> > + * @relative_rssi: Relative RSSI threshold in dB to restrict scan result
> > + * reporting in connected state to cases where a matching BSS is
> determined
> > + * to have better RSSI than the current connected BSS. The relative RSSI
> > + * threshold values are ignored in disconnected state.
>
> The description says "better RSSI" so I suppose it could be typed as u8.
> The last sentence is intended driver behavior
I like to leave this as s8 only. This will leave more flexibility to userspace especially in case of more than two bands in future.
> > + if (attrs[NL80211_ATTR_SCHED_SCAN_RELATIVE_RSSI]) {
> > + request->relative_rssi = nla_get_s8(
> > + attrs[NL80211_ATTR_SCHED_SCAN_RELATIVE_RSSI]);
> > + request->relative_rssi_set = true;
> > + }
> > +
> > + if (attrs[NL80211_ATTR_SCHED_SCAN_RSSI_ADJUST]) {
>
> Maybe I misread but I thought this attribute to be applicable only if
> request->relative_rssi_set is true.
@relative_rssi is valid only when @relative_rssi_set is set to true and @rssi_adjust is valid only when @relative_rssi is valid. I think that is understandable to drivers and there is no need of explicit check here.
> >
> > -static int nl80211_send_wowlan_nd(struct sk_buff *msg,
> > +static int nl80211_send_wowlan_nd(struct wiphy *wiphy,
>
> This seems to be unrelated change. At least I do not see any reference to wiphy
> variable in the added code below.
My bad, Will remove this unnecessary change and upload a patch.
Thanks,
Vamsi
