On 2017-01-10 11:56, Johannes Berg wrote: > On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >> > I wonder if MAC80211 should be doing IGMP snooping and not bridge >> > in this environment. >> >> In the long term, yes. For now, not quite sure. > > There's no "for now" in the kernel. Code added now will have to be > maintained essentially forever. I'm not sure that putting the IGMP snooping code in mac80211 is a good idea, that would be quite a bit of code duplication. This implementation works, it's very simple, and it's quite flexible for a number of use cases. Is there any remaining objection to merging this in principle (aside from potential issues with the code)? - Felix
