Hi Rahul, On Sat, Jan 7, 2017 at 2:20 AM, Rahul Krishnan <mrahul.krishnan@xxxxxxxxx> wrote: > This patch removes unnecessary return statement using spatch. This doesn't describe the patch. > Signed-off-by: Rahul Krishnan <mrahul.krishnan@xxxxxxxxx> > --- > drivers/ssb/main.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > index d1a7507..ae3b7fe 100644 > --- a/drivers/ssb/main.c > +++ b/drivers/ssb/main.c > @@ -1,4 +1,4 @@ > -/* > + patch /home/rahul/git/kernels/staging/drivers//* What is the purpose of this change, won't this cause the file to fail to compile? > * Sonics Silicon Backplane > * Subsystem core > * > @@ -1272,9 +1272,7 @@ u32 ssb_admatch_size(u32 adm) > default: > SSB_WARN_ON(1); > } > - size = (1 << (size + 1)); > - > - return size; > + return (1 << (size + 1)); Is the size variable used elsewhere? If not, it's declaration should probably be removed. Also, there should be a blank line before the return statement. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/
