On Fri, Jun 6, 2008 at 3:39 AM, Rindjunsky, Ron <ron.rindjunsky@xxxxxxxxx> wrote: >>> Rename tx_info to info as used by other drivers. This will help >>> with CONFIG_NETDEVICES_MULTIQUEUE requirement for HT support support >>> in compat-wireless by allowing us to map skb_get_queue_mapping(skb) >>> to the old info->queue. >>> >>> An alternative is to maintain a large compat.diff which replaces all >>> skb_get_queue_mapping(skb) calls back to info->queue but since this >>> is the only driver which requires name change it seems worth it >>> to help with maintenance. >>> >>> Compat-wireless shouldn't be a reason to accept patches in but if >>> the changes are just cosmetic it seems worth the benefit. >>> >>> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxx> > >> That's just asking for trouble. If you really _must_ do magic in >> skb_get_queue_mapping, do it directly: > >> int q = IEEE80211_SKB_CB(skb)->queue; > > Aren't we heading into to troubles here? In kernels < 2.6.23 there is no > skb->queue_mapping. queue was once passed in the cb, but now that queue > was removed from info and info takes cb we are going to have a compat > problem. This is only going to be done for <= 2.6.22. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
