On 2 January 2017 at 14:38, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > >> --- a/include/net/cfg80211.h >> +++ b/include/net/cfg80211.h >> @@ -3730,8 +3730,8 @@ static inline const char *wiphy_name(const >> struct wiphy *wiphy) >> * Return: A pointer to the new wiphy. This pointer must be >> * assigned to each netdev's ieee80211_ptr for proper operation. >> */ >> -struct wiphy *wiphy_new_nm(const struct cfg80211_ops *ops, int >> sizeof_priv, >> - const char *requested_name); >> +struct wiphy *wiphy_new_nm(struct device *dev, const struct >> cfg80211_ops *ops, >> + int sizeof_priv, const char >> *requested_name); > > This is obviously missing documentation updates. > >> */ >> -static inline struct wiphy *wiphy_new(const struct cfg80211_ops >> *ops, >> +static inline struct wiphy *wiphy_new(struct device *dev, >> + const struct cfg80211_ops >> *ops, > > Ditto. > > It looks like you practically removed all users of set_wiphy_dev(), why > not do that completely and remove that entirely? There are 2 users left: 1) ipw2x00 - I missed that one 2) mac80211 - it's a big one as it's used in SET_IEEE80211_DEV I was planning to work on mac80211 drivers later. This will require similar modification of ieee80211_alloc_hw. -- Rafał