Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> writes:
> On Thu, Dec 29, 2016 at 3:11 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
>> Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> wrote:
>>> The 10.4 firmware adds extended peer information to the
>>> firmware's statistics payload. This additional info is
>>> stored as a separate data field and the elements are
>>> stored in their own "peers_extd" list.
>>>
>>> These elements can pile up in the same way as the peer
>>> information elements. This is because the
>>> ath10k_wmi_10_4_op_pull_fw_stats() function tries to
>>> pull the same amount (num_peer_stats) for every statistic
>>> data unit.
>>>
>>> Fixes: 4a49ae94a448faa ("ath10k: fix 10.4 extended peer stats update")
>>> Signed-off-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
>>
>> My understanding is that I should skip this patch 1. Please let me know if
>> I misunderstood. But I'm still plannning to apply patch 2.
>
> I added Mohammed (I hope, he can reply to the open question when he
> returns), Since I'm not sure what he wants or not.
>
> As far as I'm aware, the "extended" boolean serves no purpose
> because it was only used in once place in debugfs_sta which was
> removed in the patch. ( "ath10k_sta_update_stats_rx_duration"
> and "ath10k_sta_update_extd_stats_rx_duration" have been unified).
I had problems following the discussion so the conclusion was not clear
for me.
>> Patch set to Changes Requested.
>
> Isn't there a: "Waiting for Maintainer" state as well?
> Otherwise, if nobody has any complains or question:
> can you please queue it for the next merge window?
There is a state called "Deferred" which I use whenever I need to
revisit a patch later time. I moved this patch to that state now:
https://patchwork.kernel.org/patch/9461631/
--
Kalle Valo
