On Thursday 05 June 2008, Luis R. Rodriguez wrote: > On Thu, Jun 5, 2008 at 6:16 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Thu, 2008-06-05 at 09:07 -0400, Luis R. Rodriguez wrote: > >> Rename tx_info to info as used by other drivers. This will help > >> with CONFIG_NETDEVICES_MULTIQUEUE requirement for HT support support > >> in compat-wireless by allowing us to map skb_get_queue_mapping(skb) > >> to the old info->queue. > >> > >> An alternative is to maintain a large compat.diff which replaces all > >> skb_get_queue_mapping(skb) calls back to info->queue but since this > >> is the only driver which requires name change it seems worth it > >> to help with maintenance. > >> > >> Compat-wireless shouldn't be a reason to accept patches in but if > >> the changes are just cosmetic it seems worth the benefit. > >> > >> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxx> > > > > That's just asking for trouble. If you really _must_ do magic in > > skb_get_queue_mapping, do it directly: > > > > int q = IEEE80211_SKB_CB(skb)->queue; > > Works for me, thanks. Please ignore patch, or not if you want drivers > for some strange reason to be consistent. I just don't need it now. Thanks, I'll drop the patch. ;) Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
