* Kalle Valo <kvalo@xxxxxxxxxxxxxx> [161220 09:12]: > Tony Lindgren <tony@xxxxxxxxxxx> writes: > > > * Kalle Valo <kvalo@xxxxxxxxxxxxxx> [161220 03:47]: > >> Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > >> > >> > On 18-12-2016 13:09, Pali Rohár wrote: > >> > > >> >> File wl1251-nvs.bin is provided by linux-firmware package and contains > >> >> default data which should be overriden by model specific calibrated > >> >> data. > >> > > >> > Ah. Someone thought it was a good idea to provide the "one ring to rule > >> > them all". Nice. > >> > >> Yes, that was a bad idea. wl1251-nvs.bin in linux-firmware.git should be > >> renamed to wl1251-nvs.bin.example, or something like that, as it should > >> be only installed to a real system only if there's no real calibration > >> data available (only for developers to use, not real users). > > > > Makes sense to me. Note that with the recent changes to wlcore, we can > > now easily provide board specific calibration firmware simply by adding a > > new compatible value. So for n900, we could have something like > > compatible = "ti,wl1251-n900" and have it point to n900 specific calibration > > file wl1251-nvs-n900.bin. Of course this won't help with the mac address, > > or any of the device specific data.. > > > > That is assuming the calibration values are the same for each similar > > device and don't have to be generated for each device. And naturally wl1251 > > needs simlar changes done to make use of devices specific calibration files. > > No, these are unique per each sold device. Every N900 was calibrated at > the factory and they all have different calibration data which is stored > to the flash. So when N900 boots (and in _every_ boot) it has to load > the calibration data from the flash and provide it to the wl1251 driver > somehow. Urgh, OK. So much for that idea then. Thanks, Tony
