On 13 December 2016 at 11:11, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > >> I wasn't clear: nl80211 sets the thresholds so that "high" is higher >> than last known value and "low" is lower than last known value, also >> the distance is at least 2 x hysteresis. There's no purpose for >> reporting "middle" rssi events because we have to set a new range as >> soon as we receive a high or a low event. I realize I need to >> document better. > > But there can be a delay between reporting and reprogramming, and if > during that time a new event could be reported? I guess it doesn't > matter much if we assume that upon reprogramming the driver will always > report a new event if the current value falls outside the new range That's the intention, I'm not sure if the comments in the code are enough to make it clear. > (either high or low)... it just seemed a little bit more consistent to > unconditionally report a new event at the beginning, even if that new > event is "yup - falling into the middle of your range now". I can add a new value to the enum for "middle". I think we'd definitely want it if it was a userspace API but this is the internal api with just this one use. Also some drivers will have to query the firmware for the new value and may need an additional wake-up for every RSSI wake-up, doubling the amount of work. Best regards
