On 12-12-2016 18:43, Dan Williams wrote: >> + >> +/** >> + * enum nl80211_bucket_band - GScan bucket band selection. > Quite possibly this was already covered and somebody requested you to > change this to the current name. If that's the case, ignore this. Nope. You are the first ;-) > But shouldn't this enum and bucket_event_report include "gscan" in > their name, like the other gscan specific stuff does? Are these going > to get used for something else too, and will that thing make sense with > the word "bucket"? Just "nl80211_bucket_band" is pretty generic. I figured the term bucket was making it gscan specific, but you are right. Will change it. Thanks, Arend