Hi, On 6 December 2016 at 22:42, Denis Kenzior <denkenz@xxxxxxxxx> wrote: > On 12/06/2016 01:16 AM, Johannes Berg wrote: >> Anyway ... I'm not even super against this patch, but you need to fix >> things: >> * this is actually wrong for authenticate - I'll let you figure out >> why by yourself > > > So here's a quick test, with the client triggering authenticate, then > crashing: > > < Request: Authenticate (0x25) len 52 [ack] 362.339712 > Interface Index: 3 (0x00000003) > Wiphy Frequency: 2417 (0x00000971) > MAC Address <snip> > SSID: len 9 > <snip> > Auth Type: 0 (0x00000000) >> Event: New Station (0x13) len 32 362.341337 > Interface Index: 3 (0x00000003) >> Response: Authenticate (0x25) len 4 362.341860 > Status: Success (0) >> Event: Authenticate (0x25) len 64 362.343640 > Wiphy: 0 (0x00000000) > Interface Index: 3 (0x00000003) >> Event: Del Station (0x14) len 1144 367.442024 > Interface Index: 3 (0x00000003) > MAC Address <snip> > > Pay attention to the time stamps. The del station event comes in 5 seconds > or so after our client has aborted. So for 5 seconds we have an unmanaged > link to some AP. It would be nice if the authentication was aborted as soon > as we crash. > > So again, why do you say that SOCKET_OWNER is 'wrong' for authenticate? Or > do you mean something else? Possibly Johanness refers to the fact that if you use CMD_AUTHENTICATE, or if you use CMD_CONNECT but the driver implements the SME -- doesn't use the cfg80211 software SME -- then cfg80211_disconnect won't do anything if we're not associated, only authenticated. Currently cfg80211 doesn't have knowledge of whether it is authenticated and where to. With the software SME current_bss would be set from the moment the authentication attempt starts, so there seems to be an inconsistency which would affect for example the NL80211_BSS_STATUS_ASSOCIATED flags in the result of CMD_GET_SCAN. Perhaps this can be fixed by always setting current_bss on auth attempt start, with flags to indicate whether authentication has happened and whether association happened. At the very least with this patch if you set the socket owner during CMD_AUTHENTICATE and then separately associate, you'd get the expected deauthentication. Best regards
