On Mon, Dec 05, 2016 at 11:17:28AM -0600, Larry Finger wrote: > On 12/05/2016 05:38 AM, Dan Carpenter wrote: > >On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: > >>From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > >> > >>The btcoexist routines for the RTL8192EE have been extensively rewritten. > >> > > > >This patch does a million things and is totally unreviewable. The > >patch description doesn't say what patch does or why. It's 5k lines > >of diff. What the heck??? > > I am caught in a bind. The BT coexistence routines are written by a > Realtek contractor. As I cannot get the individual patches from > Realtek, there is no chance of getting them from a 3rd party. These patches are absolutely impenetrable. A few years ago in SCSI we gave a vendor a one time pass to just merge a huge patch and sync with mainline. We could view this in the same light, except that I think when we moved this driver out of staging that was the one time pass. By now they should be proper kernel devs who can wipe their own bottoms... We maybe should merge this and move the driver back to staging until they can figure out how to maintain stuff? That's a serious suggestion. This patch is no way close to minimum quality requirements for upstream. regards, dan carpenter
