On 12/05/2016 06:53 AM, Johannes Berg wrote:
Unless I screwed up, this patch also returns an average.
Oops, sorry. I missed the whole mac_div() indirection thing.
I'm not super convinced anyway though - all of this data already is
available in a much more reliable fashion, even trackable when stations
are removed (all data gets sent in the DEL_STATION notification), so
adding a crippled way to get the same data seems a bit strange?
Ethtool stats are easy to program against, and I am already making the
get-stats call to get other things, so it was a quick tweak to return
these additional values. I agree the stats are of somewhat limited worth,
but the cost to get them is also pretty small code wise :)
In any case I'd want you to resend with the /* pr_..*/ stuff removed.
I can respin with the comment removed.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
