Rafał Miłecki <zajec5@xxxxxxxxx> writes: > On 29 November 2016 at 10:23, Arend Van Spriel > <arend.vanspriel@xxxxxxxxxxxx> wrote: >> On 29-11-2016 8:57, Johannes Berg wrote: >>> On Tue, 2016-11-29 at 08:08 +0100, Rafał Miłecki wrote: >>>> On 23 November 2016 at 11:25, Arend van Spriel >>>> <arend.vanspriel@xxxxxxxxxxxx> wrote: >>>>> >>>>> Introducing new source file for pno related functionality. Moving >>>>> existing pno functions. >>>> >>>> Let me ask one basic question as I'm curious: what that PNO stands >>>> for? I couldn't find it explained in the code. >>> >>> It's an Android term - Preferred Network Offload(ing?) >> >> Yeah. The module is called pfn in our firmware, which stands for >> preferred network. So not sure whether it was a BRCM term morphed into >> Android term or vice versa. >> >> Kalle, >> >> If needed I could drop the use of the term and resubmit the series. > > I don't have anything against it, I was just trying to understand that > part of driver (which makes more sense now, thanks). I don't have any problems as these are already implemented, you are only moving code around. But if you were adding a new feature to the driver when an explanation for the acronym is very much preferred. -- Kalle Valo