Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:
> Barry Day <briselec@xxxxxxxxx> wrote:
>> Move the dev_info call that attempts to show the rate used before it is set.
>>
>> Signed-off-by: Barry Day <briselec@xxxxxxxxx>
>
> Jes, I would like to take this directly to fix the compiler warning. Also I'll
> change the commit log to:
Kalle,
I'm totally fine with this, please go ahead.
Barry thanks for fixing this.
Cheers,
Jes
> rtl8xxxu: tx rate reported before set
>
> Move the dev_info call that attempts to show the rate used before it is set.
> Fixes a compiler warning:
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function
> 'rtl8xxxu_fill_txdesc_v2':
> include/linux/device.h:1214:36: warning: 'rate' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
>
> Fixes: b4c3d9cfb607 ("rtl8xxxu: Pass tx_info to fill_txdesc in order
> to have access to retry count")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Barry Day <briselec@xxxxxxxxx>
