Rajat Jain <rajatja@xxxxxxxxxx> writes: > On Fri, Nov 18, 2016 at 8:21 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > > @@ -10,6 +10,8 @@ Required properties: > > - compatible : should be one of the following: > > * "marvell,sd8897" > > * "marvell,sd8997" > > + * "pci11ab,2b42" > > + * "pci1b4b,2b42" > > Are these correct? In v6 Rob said: > > "I think I already said this, but you have the vendor and product IDs > reversed." > > https://patchwork.kernel.org/patch/9390225/ > > > > I had responded to it: > > > Hi Rob, > >> I think I already said this, but you have the vendor and product IDs >> reversed. > > Actually Marvell has 2 vendor IDs assigned to it. In include/linux/pci_ids.h: > > #define PCI_VENDOR_ID_MARVELL 0x11ab > #define PCI_VENDOR_ID_MARVELL_EXT 0x1b4b > > So in this case the compatible property describes a single product ID, > with both possible vendor IDs. Ok, I missed that. BTW, please avoid using HTML. text/plain is very much preferred. -- Kalle Valo
