On 17 November 2016 at 17:32, Erik Stromdahl <erik.stromdahl@xxxxxxxxx> wrote: > > > On 11/15/2016 11:19 AM, Michal Kazior wrote: >> On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl@xxxxxxxxx> wrote: >>> Code refactorization: >>> >>> Moved the code for ep 0 in ath10k_htc_rx_completion_handler >>> to ath10k_htc_control_rx_complete. >>> >>> This eases the implementation of SDIO/mbox significantly since >>> the ep_rx_complete cb is invoked directly from the SDIO/mbox >>> hif layer. >>> >>> Since the ath10k_htc_control_rx_complete already is present >>> (only containing a warning message) there is no reason for not >>> using it (instead of having a special case for ep 0 in >>> ath10k_htc_rx_completion_handler). >> >> This should be squashed with Patch 3 since it's inseparable part of >> the same refactorization. >> >> >> Michał >> > > > Hmm, I don't really see why this is an inseparable part of the previous > patch. > > As far as I see this patch has nothing to do with patch 3, or am I > missing anything? > > Are you really sure they should be squashed? Hmm.. on second thought this should be fine as it is. Michał
