Hi Kalle, > From: linux-wireless-owner@xxxxxxxxxxxxxxx [mailto:linux-wireless- > owner@xxxxxxxxxxxxxxx] On Behalf Of Kalle Valo > Sent: Friday, November 18, 2016 5:01 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > rajatja@xxxxxxxxxx; briannorris@xxxxxxxxxx; dmitry.torokhov@xxxxxxxxx; > Shengzhen Li; Amitkumar Karwar > Subject: Re: [v3, 01/11] mwifiex: check tx_hw_pending before > downloading sleep confirm > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> wrote: > > From: Shengzhen Li <szli@xxxxxxxxxxx> > > > > We may get SLEEP event from firmware even if TXDone interrupt for > last > > Tx packet is still pending. In this case, we may end up accessing > PCIe > > memory for handling TXDone after power save handshake is completed. > > This causes kernel crash with external abort. > > > > This patch will only allow downloading sleep confirm when no tx done > > interrupt is pending in the hardware. > > > > Signed-off-by: Cathy Luo <cluo@xxxxxxxxxxx> > > Signed-off-by: Shengzhen Li <szli@xxxxxxxxxxx> > > Tested-by: Xinming Hu <huxm@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > (A note to myself) > > Depends on this patchset: > > [ 12] [v4,1/3] mwifiex: Allow mwifiex early access to device st... > 2016-11-15 Amitkumar Ka Awaiting Upstream [ 13] [v4,2/3] mwifiex: > Introduce mwifiex_probe_of() to parse c... 2016-11-15 Amitkumar Ka > Awaiting Upstream > [ 14] [v4,3/3] mwifiex: Enable WoWLAN for both sdio and pcie > 2016-11-15 Amitkumar Ka Awaiting Upstream > There is a minor conflict while applying [v3, 3/11] on top of above patch series. I will submit v4 patch series(11 patches) with correction. Regards, Amitkumar