Hi Brian, > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: Saturday, November 12, 2016 2:13 AM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > rajatja@xxxxxxxxxx; dmitry.torokhov@xxxxxxxxx > Subject: Re: [PATCH v2 3/3] mwifiex: Enable WoWLAN for both sdio and > pcie > > On Fri, Nov 11, 2016 at 04:45:11PM +0530, Amitkumar Karwar wrote: > > From: Rajat Jain <rajatja@xxxxxxxxxx> > > > > Commit ce4f6f0c353b ("mwifiex: add platform specific wakeup interrupt > > support") added WoWLAN feature only for sdio. This patch moves that > > code to the common module so that all the interface drivers can use > it > > for free. It enables pcie and sdio for its use currently. > > > > Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx> > > --- > > v2: v1 doesn't apply smoothly on latest code due to recently merged > > patch "mwifiex: report error to PCIe for suspend failure". Minor > > conflict is resolved in v2 > > --- > > In case you haven't noticed my comments elsewhere, I'll repeat them > here: you're copy-and-pasting buggy code. That can be OK I suppose, but > please fix these issues, possibly in a follow-up patch. Thanks for pointing this. I will post separate follow-up patch which address this issue as per your suggestion. Regards, Amitkumar
