Search Linux Wireless

Re: [PATCH 01/11 v2] rt2x00: Calculate register offset during compile time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 03 June 2008, Johannes Berg wrote:
> 
> > +#define compile_ffs2(__x) \
> > +	( ((__x) & 0x1) ? 0 : 1 )
> > +
> > +#define compile_ffs4(__x) \
> > +	( ((__x) & 0x3) ? \
> > +	    compile_ffs2(__x) : (compile_ffs2(__x >> 2) + 2) )
> 
> It seems you should also add parentheses around the __x used in the
> recursive macro invocation, like this:
> 
> ... : (compile_ffs2((__x) >> 2) + 2) )
> 
> or am I missing something?

Nope, you are right. :)
Version 3 on its way.

Thanks,

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux