(removed Erarn Harary from the Cc list, since this email is not valid
anymore)
Hi Kirtika,
Just a couple of nitpicks, nothing important, so no need to resend.
On Tue, 2016-11-08 at 21:50 -0800, Kirtika Ruchandani wrote:
> mvmvif is defined and set in rs_mimo_allow but not used. Compiling
> iwlwifi with W=1 gives the following warning, remove it. mvmsta is used only to
> obtain mvmvif so remove it as well.
>
> iwlwifi/mvm/rs.c: In function 'rs_mimo_allow':
> iwlwifi/mvm/rs.c:165:22: warning: variable 'mvmvif' set but not used.[-Wunused-but-set-variable]
>
> This fix removes calls to iwl_mvm_sta_from_mac & iwl_mvm_vif_from_mac. They are
> both accessors, and do not have any side-effects.
> Commit e621c2282 removed a workaround that disabled MIMO on P2P, 'mvmvif' was
> used for that workaround, but not removed with it.
>
> Fixes: e621c2282e31 ("iwlwifi: rs: Remove workaround that disables MIMO on P2P")
>
Usually the Fixes: tag is together with the other tags (such as Cc,
Signed-off-by), i.e. no empty line here.
> Signed-off-by: Kirtika Ruchandani <kirtika@xxxxxxxxxx>
> Cc: Alexander Bondar <alexander.bondar@xxxxxxxxx>
> Cc: Emmanuel Grumbach <emmmanuel.grumbach@xxxxxxxxx>
And the Signed-off-by tag is usually the last one here, after all Cc's
and stuff. But it doesn't matter much.
--
Cheers,
Luca.
