On Fri, 2016-10-28 at 12:25 +0200, Arnd Bergmann wrote: > gcc -Wmaybe-uninitialized reports a bug in aes_siv_encryp: > > net/mac80211/fils_aead.c: In function ‘aes_siv_encrypt.constprop’: > net/mac80211/fils_aead.c:84:26: error: ‘tfm2’ may be used > uninitialized in this function [-Werror=maybe-uninitialized] > > At the time that the memory allocation fails, 'tfm2' has not been > allocated, so we should not attempt to free it later, and we can > simply return an error. > > Fixes: 39404feee691 ("mac80211: FILS AEAD protection for station mode > association frames") Ahrg, how did I miss that. Dave, I'll apply this, and send a new pull request. johannes