On 10/26/16 at 10:59am, Johannes Berg wrote: > > > /** > > + * nla_memdup - duplicate attribute memory (kmemdup) > > + * @src: netlink attribute to duplicate from > > + * @gfp: GFP mask > > Actually, is there any point in passing a GFP mask? None of the current > users need it, and it seems fairly unlikely to be needed since this is > typically used on the netlink input path, where you surely shouldn't > need GFP_ATOMIC or so? I'm fine either way. I didn't want to make assumptions which need later changes. It's not hurting either and the function prototype is very small.