On Wed, Oct 26, 2016 at 07:50:36AM +0200, Johannes Berg wrote: > On Wed, 2016-10-26 at 01:44 +0300, Jouni Malinen wrote: > > With the previous commits, initial FILS support is now functional in > > mac80211-based drivers for both AP and stations roles. > > That's a bit misleading, I guess AP role is handled entirely in > hostapd? You documented the extended feature bit to explicitly mean > station role only :) Yeah.. In case of mac80211, there was not really changes needed in the kernel side for AP mode. That may be different with non-mac80211 drivers, though, since they might be easier to handle with the AES-SIV operations for associations frames handled within the driver. Would you prefer to split that NL80211_EXT_FEATURE_FILS into two separate values (_STA and _AP) and have mac80211 advertise both? Or just add a _STA only case for now and see what we need to do with NL80211_ATTR_DEVICE_AP_SME cases separately once such a thing is in in functional state? -- Jouni Malinen PGP id EFC895FA
