On Wed, 2016-10-26 at 09:59 +0300, Kalle Valo wrote:
> Luca Coelho <luca@xxxxxxxxx> writes:
>
> > On Wed, 2016-10-26 at 09:19 +0300, Kalle Valo wrote:
> > > Luca Coelho <luca@xxxxxxxxx> writes:
> > >
> > > > From: Luca Coelho <luciano.coelho@xxxxxxxxx>
> > > >
> > > > When a unified D0/D3 image is used, we don't restart the FW in the
> > > > D0->D3->D0 transitions. Therefore, the d3_test functionality should
> > > > not call ieee8021_restart_hw() when the resuming either.
> > > >
> > > > Fixes: commit 23ae61282b88 ("iwlwifi: mvm: Do not switch to D3 image on suspend")
> > >
> > > The word "commit" is not needed in the Fixes line, but no need to change
> > > that now.
> >
> > Oh, I didn't know that. Thanks for pointing out. I'll keep it in mind
> > for future patches.
>
> Related to this Documentation/SubmittingPatches has a handy tip:
>
> ----------------------------------------------------------------------
> The following ``git config`` settings can be used to add a pretty format for
> outputting the above style in the ``git log`` or ``git show`` commands::
>
> [core]
> abbrev = 12
> [pretty]
> fixes = Fixes: %h (\"%s\")
> ----------------------------------------------------------------------
>
> And then you can do just:
>
> $ git show --format=fixes 23ae61282b88 | head -1
> Fixes: 23ae61282b88 ("iwlwifi: mvm: Do not switch to D3 image on suspend")
> $
>
> Perfect for a lazy person like me :)
Wow, really perfect for me too! Thanks! I should read SubmittingPatches
more often. :)
--
Luca.
