On Thursday, October 20, 2016 2:24:32 PM CEST Binoy Jayan wrote:
> Semaphore are going away in the future, so remove the unused function
> wilc_lock_timeout which calls a semaphore api but has no users.
>
> Signed-off-by: Binoy Jayan <binoy.jayan@xxxxxxxxxx>
> ---
>
> They following is a patch which removes semaphores from wilc1000.
> Its part of a bigger effort to eliminate all semaphores
> from the linux kernel.
Good catch!
> drivers/staging/wilc1000/linux_wlan.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index 6370a5e..470d59f 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -218,17 +218,6 @@ static void deinit_irq(struct net_device *dev)
> }
> }
>
> -int wilc_lock_timeout(struct wilc *nic, void *vp, u32 timeout)
> -{
> - /* FIXME: replace with mutex_lock or wait_for_completion */
> - int error = -1;
> -
> - if (vp)
> - error = down_timeout(vp,
> - msecs_to_jiffies(timeout));
> - return error;
> -}
You need to remove the prototype from wilc_wfi_netdevice.h
as well. Once you do that, please add
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
