Search Linux Wireless

Re: [PATCH] rsi: update in vap_capabilities frame to device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx> writes:

> added vap status(add/delete) field in vap capabilities frame to device
> added sending vap capabilites frame(with vap status 'delete') in remove interface
>
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx>

Why? How is this better now? I'm sure there is a good reason why you add
this but we don't know as the commit tells nothing we don't already know
just from looking at the patch.

The most important part of commit log is to answer the question "Why?",
not "What?".

>  		rsi_dbg(ERR_ZONE,
> -			"%s: Interface type %d not supported\n", __func__,
> -			vif->type);
> +			"%s: Interface type %d not supported\n",
> +			__func__, vif->type);

Unnecessary style change, please drop.

> -	rsi_dbg(MGMT_TX_ZONE, "%s: Sending VAP capabilities frame\n", __func__);
> +	rsi_dbg(MGMT_TX_ZONE,
> +		"%s: Sending VAP capabilities frame\n", __func__);

Same here.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux