> * > + * @NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED: Multicast packets > should be > + * send out as unicast to all stations. You should document what type of attribute is expected. You probably wanted a flag attribute, but ... > + [NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED] = { .type = > NLA_U8, }, have u8 in the policy, yet > + enabled = nla_get_flag(nla); actually use as a flag :) In addition to that, I think you should clarify the "per-BSS" comment in nl80211, and also clarify (at the same place) what kind of functionality is expected from this. johannes