Re: [RFC] mac80211: fix A-MSDU outer SA/DA

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

>  
> +	/* according to IEEE 802.11-2012 8.3.2 table 8-19, the outer
> SA/DA
> +	 * fields needs to be changed to BSSID for A-MSDU frames
> depending
> +	 * on FromDS/ToDS values.
> +	 */
> +	hdr = data;
> +	if (bssid && (hdr->frame_control &
> cpu_to_le16(IEEE80211_FCTL_FROMDS)))
> +		memcpy(amsdu_hdr.h_source, bssid, ETH_ALEN);
> +	if (bssid && (hdr->frame_control &
> cpu_to_le16(IEEE80211_FCTL_TODS)))
> +		memcpy(amsdu_hdr.h_dest, bssid, ETH_ALEN);
> 

You should probably use ieee80211_has_tods() and ieee80211_has_fromds()

johannes