On Tue, Oct 04, 2016 at 03:25:51PM +0200, Johannes Berg wrote: > > ath6kl: > > Use cfg80211_get_chandef_type(&info->chandef) != NL80211_CHAN_NO_HT > > to determine whether HT is enabled. No VHT support. HT-required case > > not covered. No parsing of HT/VHT IEs used. > > Hmm. Wouldn't the supported rates IE still advertise the cookie for HT > only, to make sure HT-required was done? I'm not completely sure how the driver/firmware behaves for this. There is a reference to info->beacon.head, but that code looks like dead code that does nothing as far as configuring the firmware with the supported rates elements from user space. As such, I'd expect the firmware to build (Ext)Supp Rates element from scratch and I'd assume ath6kl does not currently support HT-required signaling. I'm not sure whether the current firmware would even allow such configuration. > [snip other drivers] By the way, I did not find any clear example that would be either using (Extended) Supported Rates element from start_ap() as-is or parsing it for the BSS membership selectors in any of the in-tree drivers. In other words, the HT/VHT required configuration may not really work properly with non-mac80211 cases. PS. And even if the driver were to simply copy the IEs with the BSS membership selectors, this would only work with stations that implement this part correctly, i.e., the AP would not necessarily have any means for rejecting the association if a non-HT/VHT station were to try to associate.. With mac80211-drivers, this happens in hostapd. -- Jouni Malinen PGP id EFC895FA
