On Friday 30 September 2016, Felix Fietkau wrote: > >> >> >> + device_type = "pci"; > >> >> >> + mediatek,mtd-eeprom = <&factory 0x8000>; > >> >> >> + mediatek,2ghz = <0>; > >> > > >> > It's not clear what the possible values for the 2ghz property are, > >> > can you be more verbose in the description? How is <0> different > >> > from no property? > >> 0 means disabled, no property means unchanged (compared to EEPROM). > > > > Maybe have a boolean property instead then to say "mediatek,2ghz-disabled" ? > > > > If zero is the only possible value, there is no need to put a number in there. > 1 is also possible, which will force-enable the capability. Ok, then both those values should be documented in the binding. Arnd
